]> xenbits.xensource.com Git - libvirt.git/commit
maint: avoid locale-sensitivity in string case comparisons
authorEric Blake <eblake@redhat.com>
Thu, 31 Mar 2011 02:26:27 +0000 (20:26 -0600)
committerEric Blake <eblake@redhat.com>
Thu, 31 Mar 2011 02:26:27 +0000 (20:26 -0600)
commit6c9e89bbd2ff78fdbf0a6e7ba88d604b2da655c8
tree5c85116deb05e83964a58ef67bf5a275656b4d8c
parent06732e1a7d6c81f1df03ecb24e0786d8ea92b249
maint: avoid locale-sensitivity in string case comparisons

strcase{cmp/str} have the drawback of being sensitive to the global
locale; this is unacceptable in a library setting.  Prefer a
hard-coded C locale alternative for all but virsh, which is user
facing and where the global locale isn't changing externally.

* .gnulib: Update to latest, for c-strcasestr change.
* bootstrap.conf (gnulib_modules): Drop strcasestr, add c-strcase
and c-strcasestr.
* cfg.mk (sc_avoid_strcase): New rule.
(exclude_file_name_regexp--sc_avoid_strcase): New exception.
* src/internal.h (STRCASEEQ, STRCASENEQ, STRCASEEQLEN)
(STRCASENEQLEN): Adjust offenders.
* src/qemu/qemu_monitor_text.c (qemuMonitorTextEjectMedia):
Likewise.
* tools/virsh.c (namesorter): Document exception.
.gnulib
bootstrap.conf
cfg.mk
src/internal.h
src/qemu/qemu_monitor_text.c
tools/virsh.c