]> xenbits.xensource.com Git - people/pauldu/qemu.git/commit
pci: Make query-pci stub consistent with the real one
authorMarkus Armbruster <armbru@redhat.com>
Thu, 1 Dec 2022 12:11:24 +0000 (13:11 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Mon, 19 Dec 2022 15:21:56 +0000 (16:21 +0100)
commit6be4ddffd09a3b184338ecb07ce3539732e00ba1
treee818f2423a2b7ac369bd1a3bebe7316de9e7ea87
parent5ef4a0cb63231845bd2a7d749ed2335a1ce35091
pci: Make query-pci stub consistent with the real one

QMP query-pci and HMP info pci can behave differently when there are
no PCI devices.  They can report nothing, like this:

    qemu-system-aarch64 -S -M spitz -display none -monitor stdio
    QEMU 7.1.91 monitor - type 'help' for more information
    (qemu) info pci

Or they can fail, like this:

    qemu-system-microblaze -M petalogix-s3adsp1800 -display none -monitor stdio
    QEMU 7.1.91 monitor - type 'help' for more information
    (qemu) info pci
    PCI devices not supported

They fail when none of the target's machines supports PCI, i.e. when
we're using qmp_query_pci() from hw/pci/pci-stub.c.

The error is not useful, and reporting nothing makes sense, so do that
in pci-stub.c, too.

Now qmp_query_pci() can't fail anymore.  Drop the dead error handling
from hmp_info_pci().

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20221201121133.3813857-5-armbru@redhat.com>
hw/pci/pci-hmp-cmds.c
hw/pci/pci-stub.c