]> xenbits.xensource.com Git - people/pauldu/qemu.git/commit
hw/arm/virt: Use "msi-map" devicetree property for PCI
authorJean-Philippe Brucker <jean-philippe@linaro.org>
Tue, 27 Sep 2022 10:03:44 +0000 (11:03 +0100)
committerPeter Maydell <peter.maydell@linaro.org>
Thu, 29 Sep 2022 16:55:05 +0000 (17:55 +0100)
commit6b2f3ac945b75f548ab7ca37ac239dc981f7dfc3
tree07914af9717d12803111cfaa8f925b5abd331ca2
parenta312a530076cb24414f193d3e6279b882a8288ff
hw/arm/virt: Use "msi-map" devicetree property for PCI

The "msi-parent" property can be used on the PCI node when MSIs do not
contain sideband data (device IDs) [1]. In QEMU, MSI transactions
contain the requester ID, so the PCI node should use the "msi-map"
property instead of "msi-parent". In our case the property describes an
identity map between requester ID and sideband data.

This fixes a warning when passing the DTB generated by QEMU to dtc,
following a recent change to the GICv3 node:

  Warning (msi_parent_property): /pcie@10000000:msi-parent: property size (4) too small for cell size 1

[1] linux/Documentation/devicetree/bindings/pci/pci-msi.txt

Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Message-id: 20220927100347.176606-4-jean-philippe@linaro.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
hw/arm/virt.c