]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commit
The new generic domain re-factor introduced a small regression into the drive
authorChris Lalancette <clalance@redhat.com>
Tue, 29 Jul 2008 12:09:21 +0000 (12:09 +0000)
committerChris Lalancette <clalance@redhat.com>
Tue, 29 Jul 2008 12:09:21 +0000 (12:09 +0000)
commit654c5714bf24523e7096abd557422386c4b427f9
treef786db370fee85b3d315ca83c552b3bc27065faf
parent4779e0bcb266bd010858dba0253b383f84c6ab4a
The new generic domain re-factor introduced a small regression into the drive
handling code.  In particular, if you had a section of XML like:

    <disk type='file' device='cdrom'>
      <target dev='hdc' bus='ide'/>
      <readonly/>
    </disk>

This used to work with older libvirt, but now fails.  This is because we are
actually passing the literal string (null) to the qemu command-line, which qemu
barfs on.  This patch fixes it up by making it blank, which allows qemu to
continue on it's merry way.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
ChangeLog
src/qemu_conf.c
tests/qemuxml2argvdata/qemuxml2argv-disk-cdrom-empty.args [new file with mode: 0644]
tests/qemuxml2argvdata/qemuxml2argv-disk-cdrom-empty.xml [new file with mode: 0644]
tests/qemuxml2argvtest.c