]> xenbits.xensource.com Git - libvirt.git/commit
XML <source bridge='VMnet0'/> update in <interface type='bridge'/>
authorKristina Hanicova <khanicov@redhat.com>
Wed, 24 Mar 2021 16:47:44 +0000 (17:47 +0100)
committerJán Tomko <jtomko@redhat.com>
Thu, 1 Apr 2021 11:36:35 +0000 (13:36 +0200)
commit6336fcd9f82e4d75f85ccfe22b9b8f5bb3df4fd4
tree100ac80a79496c3d6d7ad753038f19308b1cccc5
parent65c371fc69f59b6d0e5c3cc8fe7735dc5788eb79
XML <source bridge='VMnet0'/> update in <interface type='bridge'/>

Previously, we accepted empty bridge name, because some old versions of
VMWare Workstation did not put it into the config. But this doesn't make
much sense - to have an interface type bridge with no name. We
circumvented this problem by generating an empty name but that is
equally wrong.

Therefore, fill in missing bridge names (according to the documentation
[1] the default bridge name is VMnet0) and error out if bridge name is
missing.

This partially reverts f246cdb5aca13ac9409b2ad43087e3078615ffcb

1: https://docs.vmware.com/en/VMware-Workstation-Player-for-Linux/16.0/com.vmware.player.linux.using.doc/GUID-BAFA66C3-81F0-4FCA-84C4-D9F7D258A60A.html

Signed-off-by: Kristina Hanicova <khanicov@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Signed-off-by: Ján Tomko <jtomko@redhat.com>
src/vmx/vmx.c
tests/vmx2xmldata/vmx2xml-fusion-in-the-wild-1.vmx
tests/vmx2xmldata/vmx2xml-fusion-in-the-wild-1.xml
tests/vmx2xmldata/vmx2xml-ws-in-the-wild-2.vmx
tests/vmx2xmldata/vmx2xml-ws-in-the-wild-2.xml
tests/xml2vmxdata/xml2vmx-fusion-in-the-wild-1.vmx
tests/xml2vmxdata/xml2vmx-fusion-in-the-wild-1.xml
tests/xml2vmxdata/xml2vmx-ws-in-the-wild-2.vmx
tests/xml2vmxdata/xml2vmx-ws-in-the-wild-2.xml