]> xenbits.xensource.com Git - qemu-xen.git/commit
edid: silence a stringop-overflow warning
authorMarc-André Lureau <marcandre.lureau@redhat.com>
Sat, 10 Nov 2018 11:16:23 +0000 (15:16 +0400)
committerGerd Hoffmann <kraxel@redhat.com>
Mon, 12 Nov 2018 13:14:18 +0000 (14:14 +0100)
commit627c865d22d63aadcf2909fe0476768bcdeef65c
tree5bf368ffad27960b0b0b06bd9dca1657f0e99ca0
parentc0188e69d336b5c921e026b3307e70b6ea7e9a47
edid: silence a stringop-overflow warning

Simplify the code that doesn't need strncpy() since length of string
is already computed.

/home/elmarco/src/qemu/hw/display/edid-generate.c: In function 'edid_desc_text':
/home/elmarco/src/qemu/hw/display/edid-generate.c:168:5: error: 'strncpy' specified bound depends on the length of the source argument [-Werror=stringop-overflow=]
     strncpy((char *)(desc + 5), text, len);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/elmarco/src/qemu/hw/display/edid-generate.c:164:11: note: length computed here
     len = strlen(text);
           ^~~~~~~~~~~~
cc1: all warnings being treated as errors

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Message-id: 20181110111623.31356-1-marcandre.lureau@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
hw/display/edid-generate.c