]> xenbits.xensource.com Git - xtf.git/commit
build: Fix build with binutils 2.36
authorAndrew Cooper <andrew.cooper3@citrix.com>
Mon, 17 May 2021 09:48:57 +0000 (10:48 +0100)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Mon, 17 May 2021 10:01:04 +0000 (11:01 +0100)
commit5ead491e36af6cb8681fc1278bd36c756ad62ac2
tree06f6f800be0ce81986764c88136b08a804ae6c61
parent880092854e5473558af77289bb7c01a9fa9dda5a
build: Fix build with binutils 2.36

Passing -no-pie to ld has never been correct, and binutils 2.36 now objects
properly to it.  https://sourceware.org/bugzilla/show_bug.cgi?id=27050

When this workaround was introduced, we used $(CC) to link, but this was
adjusted back to $(LD) with c/s 8486a388e2 ("build: Use LD").

However, the adjustment should always have been passed to the compile step,
not the link step.  Move the adjustment into COMMON_CFLAGS.

Fixes: c92015f8ab ("build: disable PIE during linking if necessary")
Fixes: 8486a388e2 ("build: Use LD")
Reported-by: Damien Thenot <damien.thenot@vates.fr>
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
build/common.mk