]> xenbits.xensource.com Git - arm/linux.git/commit
iommu/vt-d: Call __dmar_remove_one_dev_info with valid pointer
authorJerry Snitselaar <jsnitsel@redhat.com>
Wed, 22 Jan 2020 00:34:26 +0000 (17:34 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Jan 2020 15:45:27 +0000 (16:45 +0100)
commit5d1973adcfffa180cb474ee55db0d990eb833378
treeead38249676cdf8c86d01a9872af860932375bd0
parentd4616a9f8ee9d8a05fa9f36901d91ed6a0a49e1e
iommu/vt-d: Call __dmar_remove_one_dev_info with valid pointer

commit bf708cfb2f4811d1948a88c41ab96587e84ad344 upstream.

It is possible for archdata.iommu to be set to
DEFER_DEVICE_DOMAIN_INFO or DUMMY_DEVICE_DOMAIN_INFO so check for
those values before calling __dmar_remove_one_dev_info. Without a
check it can result in a null pointer dereference. This has been seen
while booting a kdump kernel on an HP dl380 gen9.

Cc: Joerg Roedel <joro@8bytes.org>
Cc: Lu Baolu <baolu.lu@linux.intel.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: stable@vger.kernel.org # 5.3+
Cc: linux-kernel@vger.kernel.org
Fixes: ae23bfb68f28 ("iommu/vt-d: Detach domain before using a private one")
Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com>
Acked-by: Lu Baolu <baolu.lu@linux.intel.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iommu/intel-iommu.c