]> xenbits.xensource.com Git - libvirt.git/commit
remote: delete the avahi mDNS support
authorDaniel P. Berrangé <berrange@redhat.com>
Wed, 19 Jun 2019 14:19:23 +0000 (15:19 +0100)
committerDaniel P. Berrangé <berrange@redhat.com>
Fri, 21 Jun 2019 11:59:42 +0000 (12:59 +0100)
commit5a148ce846a9d68af28fec1ebbc0e3bb6a38d81c
tree074c2356382e730d824e8d9ea037b1a008e48cd3
parente10310d641365c83f4588670ac57e93d032db7f4
remote: delete the avahi mDNS support

Libvirtd has long had integration with avahi for advertising libvirtd
using mDNS when TCP/TLS listening is enabled. For a long time the
virt-manager application had support for auto-detecting libvirtds
on the local network using mDNS, but this was removed last year

  commit fc8f8d5d7e3ba80a0771df19cf20e84a05ed2422
  Author: Cole Robinson <crobinso@redhat.com>
  Date:   Sat Oct 6 20:55:31 2018 -0400

    connect: Drop avahi support

    Libvirtd can advertise itself over avahi. The feature is disabled by
    default though and in practice I hear of no one actually using it
    and frankly I don't think it's all that useful

    The 'Open Connection' wizard has a disproportionate amount of code
    devoted to this feature, but I don't think it's useful or worth
    maintaining, so let's drop it

I've never heard of any other applications having support for using
mDNS to detect libvirtd instances. Though it is theoretically possible
something exists out there, it is clearly going to be a niche use case
in the virt ecosystem as a whole.

By removing avahi integration we can cut down the dependency chain for
the basic libvirtd install and reduce our code maint burden.

Reviewed-by: Ján Tomko <jtomko@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
36 files changed:
cfg.mk
configure.ac
docs/internals/rpc.html.in
docs/remote.html.in
docs/windows.html.in
libvirt.spec.in
m4/virt-avahi.m4 [deleted file]
mingw-libvirt.spec.in
po/POTFILES
src/libvirt_remote.syms
src/locking/lock_daemon.c
src/logging/log_daemon.c
src/lxc/lxc_controller.c
src/remote/libvirtd.aug
src/remote/libvirtd.conf
src/remote/remote_daemon.c
src/remote/remote_daemon_config.c
src/remote/remote_daemon_config.h
src/remote/test_libvirtd.aug.in
src/rpc/Makefile.inc.am
src/rpc/virnetdaemon.c
src/rpc/virnetserver.c
src/rpc/virnetserver.h
src/rpc/virnetservermdns.c [deleted file]
src/rpc/virnetservermdns.h [deleted file]
tests/virconfdata/libvirtd.conf
tests/virconfdata/libvirtd.out
tests/virnetdaemondata/input-data-admin-nomdns.json [deleted file]
tests/virnetdaemondata/input-data-admin.json [new file with mode: 0644]
tests/virnetdaemondata/input-data-initial-nomdns.json [deleted file]
tests/virnetdaemondata/input-data-initial.json
tests/virnetdaemondata/output-data-admin-nomdns.json [deleted file]
tests/virnetdaemondata/output-data-admin.json [new file with mode: 0644]
tests/virnetdaemondata/output-data-initial-nomdns.json [deleted file]
tests/virnetdaemondata/output-data-initial.json
tests/virnetdaemontest.c