]> xenbits.xensource.com Git - qemu-xen.git/commit
hw/acpi: Dumb down acpi_table_add() stub
authorMarkus Armbruster <armbru@redhat.com>
Tue, 7 Feb 2023 07:51:09 +0000 (08:51 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Thu, 23 Feb 2023 13:10:17 +0000 (14:10 +0100)
commit588c13fcb015896e4d1f7a516d8ce6336e64133b
tree0afe9dd4d582461086c1d364525c9acdb830b1b7
parent0ca6745c74778d84c05ca2144cf0d15f8bfe26d8
hw/acpi: Dumb down acpi_table_add() stub

The QERR_ macros are leftovers from the days of "rich" error objects.
We've been trying to reduce their remaining use.

acpi_table_add() is only ever called on behalf of CLI option
-acpitable.  Since qemu-options.hx sets @arch_mask to QEMU_ARCH_I386,
it is reachable only for these targets.  Since they provide a real
acpi_table_add(), the stub is unreachable.

There's no point in unreachable code keeping QERR_UNSUPPORTED alive.
Dumb it down to g_assert_not_reached().

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230207075115.1525-7-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Juan Quintela <quintela@redhat.com>
hw/acpi/acpi-stub.c