]> xenbits.xensource.com Git - xen.git/commit
x86/HVM: restrict HVMOP_set_mem_type
authorJan Beulich <jbeulich@suse.com>
Tue, 29 Apr 2014 13:31:28 +0000 (15:31 +0200)
committerJan Beulich <jbeulich@suse.com>
Tue, 29 Apr 2014 13:31:28 +0000 (15:31 +0200)
commit560d630110f9f11fe6a0bd18522d0e2bea9ab401
tree18ef088e5e2d8c409c90fc5d171ace68e3146af2
parent9811c9bc85e648859f3a48478640ce2c696c9d06
x86/HVM: restrict HVMOP_set_mem_type

Permitting arbitrary type changes here has the potential of creating
present P2M (and hence EPT/NPT/IOMMU) entries pointing to an invalid
MFN (INVALID_MFN truncated to the respective hardware structure field's
width). This would become a problem the latest when something real sat
at the end of the physical address space; I'm suspecting though that
other things might break with such bogus entries.

Along with that drop a bogus (and otherwise becoming stale) log
message.

Afaict the similar operation in p2m_set_mem_access() is safe.

This is XSA-92.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Tim Deegan <tim@xen.org>
master commit: 83bb5eb4d340acebf27b34108fb1dae062146a68
master date: 2014-04-29 15:11:31 +0200
xen/arch/x86/hvm/hvm.c