]> xenbits.xensource.com Git - xen.git/commit
iommu/crash: Interrupt remapping is also disabled on crash
authorAndrew Cooper <andrew.cooper3@citrix.com>
Tue, 16 Apr 2013 08:34:32 +0000 (10:34 +0200)
committerJan Beulich <jbeulich@suse.com>
Tue, 16 Apr 2013 08:34:32 +0000 (10:34 +0200)
commit53fd1d8458de01169dfb56feb315f02c2b521a86
treeebad11575cf7fbcd0cb6600b2e754bf0d5dd1511
parentf03b5006f7e6e396746a56f5f563fb0f55cabc44
iommu/crash: Interrupt remapping is also disabled on crash

This fixes a regression side-effect caused by:
  IOMMU: properly check whether interrupt remapping is enabled
    git: fae0372140befb88d890a30704a8ec058c902af8
     hg: 26742:e1ec14bad0cb

On the crash path in nmi_shootdown_cpus(), we shut down the IOMMU, then
disable the IOAPIC.

On systems which support interrupt remapping, the variable iommu_intremap
remains set, meaning that disable_IO_APIC() issues interrupt remapping
invalidate requests.

IOAPIC interrupt remapping used to be conditional on iommu_enabled, but is now
conditional on iommu_intremap, following the above changeset.

This behaviour can be fixed by also indicating that interrupt remapping is not
enabled after shutting down the IOMMU.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
xen/drivers/passthrough/iommu.c