]> xenbits.xensource.com Git - libvirt.git/commit
qemu: Don't drop firmware type/features information
authorAndrea Bolognani <abologna@redhat.com>
Tue, 14 Mar 2023 22:08:29 +0000 (23:08 +0100)
committerAndrea Bolognani <abologna@redhat.com>
Wed, 22 Mar 2023 12:49:53 +0000 (13:49 +0100)
commit50d68c1d10f9e02be455cf8606bbc40528ea5ca9
tree8e411f14d2bee51cee127024c1367be228fdc649
parenta0065f97281f70d8c2017ca25c23f16120cee399
qemu: Don't drop firmware type/features information

Now that we no longer reject configurations that include both
this information and explicit firmware details, as long of
course as everything is internally consistent, and that we've
ensured that we produce maximally compatible XML on migration,
we can stop stripping this information at the end of the
firmware selection process.

There are several advantages to keeping this information around:

  * if the user wants to change the firmware configuration for
    an existing VM, they can simply drop the <loader> and
    <nvram> elements, tweak the firmware autoselection parameters
    and let libvirt pick a firmware that matches on the new
    requirements;

  * management applications can inspect the XML and easily
    figure out firmware-related information without having to
    reverse-engineer them based on some opaque paths.

Overall, this change makes things more transparent and easier to
understand. The improvement is so significant that, in a
follow-up commit, we're going to ensure that this information is
available in even more cases.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
26 files changed:
src/qemu/qemu_firmware.c
tests/qemuxml2xmloutdata/firmware-auto-bios-stateless.x86_64-latest.xml
tests/qemuxml2xmloutdata/firmware-auto-bios.x86_64-latest.xml
tests/qemuxml2xmloutdata/firmware-auto-efi-aarch64.aarch64-latest.xml
tests/qemuxml2xmloutdata/firmware-auto-efi-enrolled-keys.x86_64-latest.xml
tests/qemuxml2xmloutdata/firmware-auto-efi-format-loader-qcow2.x86_64-latest.xml
tests/qemuxml2xmloutdata/firmware-auto-efi-format-loader-raw.aarch64-latest.xml
tests/qemuxml2xmloutdata/firmware-auto-efi-format-nvram-qcow2-network-nbd.x86_64-latest.xml
tests/qemuxml2xmloutdata/firmware-auto-efi-format-nvram-qcow2-path.x86_64-latest.xml
tests/qemuxml2xmloutdata/firmware-auto-efi-format-nvram-qcow2.x86_64-latest.xml
tests/qemuxml2xmloutdata/firmware-auto-efi-loader-insecure.x86_64-latest.xml
tests/qemuxml2xmloutdata/firmware-auto-efi-loader-path.x86_64-latest.xml
tests/qemuxml2xmloutdata/firmware-auto-efi-loader-secure.x86_64-latest.xml
tests/qemuxml2xmloutdata/firmware-auto-efi-no-enrolled-keys.x86_64-latest.xml
tests/qemuxml2xmloutdata/firmware-auto-efi-no-secboot.x86_64-latest.xml
tests/qemuxml2xmloutdata/firmware-auto-efi-nvram-file.x86_64-latest.xml
tests/qemuxml2xmloutdata/firmware-auto-efi-nvram-network-iscsi.x86_64-latest.xml
tests/qemuxml2xmloutdata/firmware-auto-efi-nvram-network-nbd.x86_64-latest.xml
tests/qemuxml2xmloutdata/firmware-auto-efi-nvram.x86_64-latest.xml
tests/qemuxml2xmloutdata/firmware-auto-efi-secboot.x86_64-latest.xml
tests/qemuxml2xmloutdata/firmware-auto-efi-smm-off.x86_64-latest.xml
tests/qemuxml2xmloutdata/firmware-auto-efi-stateless.x86_64-latest.xml
tests/qemuxml2xmloutdata/firmware-auto-efi.x86_64-latest.xml
tests/qemuxml2xmloutdata/pvpanic-pci-aarch64.aarch64-latest.xml
tests/qemuxml2xmloutdata/pvpanic-pci-no-address-aarch64.aarch64-latest.xml
tests/qemuxml2xmloutdata/virtio-iommu-aarch64.aarch64-latest.xml