]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commit
Explicitly format the isa-fdc controller for newer q35 machines
authorJán Tomko <jtomko@redhat.com>
Mon, 22 Jun 2015 13:20:55 +0000 (15:20 +0200)
committerJán Tomko <jtomko@redhat.com>
Wed, 8 Jul 2015 13:35:35 +0000 (15:35 +0200)
commit4edf01c92cf9004aac2a505a38d92d13050c24bc
tree97b04fde18b1a0b31060f8ba901bb9598dfa46c9
parent4ef21ec192f0de6e638d22b6a406cd87744f6b99
Explicitly format the isa-fdc controller for newer q35 machines

Since QEMU commit ea96bc6 [1]:
i386: drop FDC in pc-q35-2.4+ if neither it nor floppy drives are wanted
the floppy controller is no longer implicit.

Specify it explicitly on the command line if the machine type version
is 2.4 or later.

Note that libvirt's floppy drives do not result in QEMU implying the
controller, because libvirt uses if=none instead of if=floppy.

https://bugzilla.redhat.com/show_bug.cgi?id=1227880

[1] http://git.qemu.org/?p=qemu.git;a=commitdiff;h=ea96bc6
src/qemu/qemu_command.c
src/qemu/qemu_domain.c
src/qemu/qemu_domain.h
tests/qemuxml2argvdata/qemuxml2argv-boot-floppy-q35.args [new file with mode: 0644]
tests/qemuxml2argvdata/qemuxml2argv-boot-floppy-q35.xml [new file with mode: 0644]
tests/qemuxml2argvdata/qemuxml2argv-bootindex-floppy-q35.args [new file with mode: 0644]
tests/qemuxml2argvdata/qemuxml2argv-bootindex-floppy-q35.xml [new file with mode: 0644]
tests/qemuxml2argvtest.c