]> xenbits.xensource.com Git - qemu-xen-4.6-testing.git/commit
fdc: force the fifo access to be in bounds of the allocated buffer
authorPetr Matousek <pmatouse@redhat.com>
Wed, 6 May 2015 07:48:59 +0000 (09:48 +0200)
committerIan Jackson <Ian.Jackson@eu.citrix.com>
Wed, 27 May 2015 15:47:38 +0000 (16:47 +0100)
commit4de1422ea306832b6ef2cba34e9febb73dd139a7
tree0be252f6861e33cd1267231364376315c253114d
parent3b45fcf0c163b9cff4d8115f7b75b42918a9b1b5
fdc: force the fifo access to be in bounds of the allocated buffer

During processing of certain commands such as FD_CMD_READ_ID and
FD_CMD_DRIVE_SPECIFICATION_COMMAND the fifo memory access could
get out of bounds leading to memory corruption with values coming
from the guest.

Fix this by making sure that the index is always bounded by the
allocated memory.

This is XSA-133 / CVE-2015-3456.

Signed-off-by: Petr Matousek <pmatouse@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
hw/fdc.c