]> xenbits.xensource.com Git - libvirt.git/commit
build: prefer mkostemp for multi-thread safety
authorEric Blake <eblake@redhat.com>
Wed, 31 Oct 2012 14:13:47 +0000 (08:13 -0600)
committerEric Blake <eblake@redhat.com>
Wed, 31 Oct 2012 16:06:10 +0000 (10:06 -0600)
commit4dbd6e9654752b3e4971e4cb69f2e09666f6b252
tree578106fdf0bf00446f1d3dca5aa6fd9e76f6f8f1
parentffa62d06a8bec3cdd37b90593020e19c9c6aed31
build: prefer mkostemp for multi-thread safety

https://bugzilla.redhat.com/show_bug.cgi?id=871756

Commit cd1e8d1 assumed that systems new enough to have journald
also have mkostemp; but this is not true for uclibc.

For that matter, use of mkstemp[s] is unsafe in a multi-threaded
program.  We should prefer mkostemp[s] in the first place.

* bootstrap.conf (gnulib_modules): Add mkostemp, mkostemps; drop
mkstemp and mkstemps.
* cfg.mk (sc_prohibit_mkstemp): New syntax check.
* tools/virsh.c (vshEditWriteToTempFile): Adjust caller.
* src/qemu/qemu_driver.c (qemuDomainScreenshot)
(qemudDomainMemoryPeek): Likewise.
* src/secret/secret_driver.c (replaceFile): Likewise.
* src/vbox/vbox_tmpl.c (vboxDomainScreenshot): Likewise.
bootstrap.conf
cfg.mk
src/qemu/qemu_driver.c
src/secret/secret_driver.c
src/vbox/vbox_tmpl.c
tools/virsh.c