]> xenbits.xensource.com Git - libvirt.git/commit
Fix many mistakes & inconsistencies in header file layout
authorDaniel P. Berrangé <berrange@redhat.com>
Thu, 13 Dec 2018 13:32:06 +0000 (13:32 +0000)
committerDaniel P. Berrangé <berrange@redhat.com>
Fri, 14 Dec 2018 10:46:53 +0000 (10:46 +0000)
commit4cfd7090212cbe38572274a7fff2475f4f8e87b7
tree62847b9049c6d6df611833aea4b64128ceb6196f
parent76ddd01ecd27e85f28e9f62641b3b1a2fffc8526
Fix many mistakes & inconsistencies in header file layout

This introduces a syntax-check script that validates header files use a
common layout:

  /*
   ...copyright header...
   */
  <one blank line>
  #ifndef SYMBOL
  # define SYMBOL
  ....content....
  #endif /* SYMBOL */

For any file ending priv.h, before the #ifndef, we will require a
guard to prevent bogus imports:

  #ifndef SYMBOL_ALLOW
  # error ....
  #endif /* SYMBOL_ALLOW */
  <one blank line>

The many mistakes this script identifies are then fixed.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
146 files changed:
build-aux/header-ifdef.pl [new file with mode: 0644]
cfg.mk
src/bhyve/bhyve_capabilities.h
src/bhyve/bhyve_parse_command.h
src/conf/domain_event.h
src/conf/domain_nwfilter.h
src/conf/netdev_vlan_conf.h
src/conf/network_event.h
src/conf/node_device_event.h
src/conf/nwfilter_conf.h
src/conf/nwfilter_params.h
src/conf/object_event.h
src/conf/object_event_private.h
src/conf/secret_conf.h
src/conf/secret_event.h
src/conf/storage_event.h
src/conf/virchrdev.h
src/conf/virnwfilterbindingdef.h
src/conf/virnwfilterbindingobj.h
src/conf/virnwfilterobj.h
src/conf/virsavecookie.h
src/datatypes.h
src/interface/interface_driver.h
src/internal.h
src/libvirt_internal.h
src/libxl/libxl_migration.h
src/locking/lock_daemon_config.h
src/logging/log_daemon_config.h
src/logging/log_handler.h
src/logging/log_manager.h
src/lxc/lxc_domain.h
src/network/bridge_driver.h
src/node_device/node_device_udev.h
src/nwfilter/nwfilter_ebiptables_driver.h
src/nwfilter/nwfilter_gentech_driver.h
src/openvz/openvz_driver.h
src/openvz/openvz_util.h
src/qemu/qemu_agent.h
src/qemu/qemu_alias.h
src/qemu/qemu_capabilities.h
src/qemu/qemu_capspriv.h
src/qemu/qemu_command.h
src/qemu/qemu_domain_address.h
src/qemu/qemu_extdevice.h
src/qemu/qemu_hotplug.c
src/qemu/qemu_hotplugpriv.h
src/qemu/qemu_migration_params.c
src/qemu/qemu_migration_paramspriv.h
src/qemu/qemu_monitor.h
src/qemu/qemu_monitor_json.h
src/qemu/qemu_monitor_priv.h
src/qemu/qemu_monitor_text.h
src/qemu/qemu_parse_command.h
src/qemu/qemu_process.c
src/qemu/qemu_processpriv.h
src/qemu/qemu_tpm.h
src/remote/remote_daemon.h
src/remote/remote_daemon_stream.h
src/rpc/virnetlibsshsession.h
src/rpc/virnetserverservice.h
src/rpc/virnetsshsession.h
src/rpc/virnettlscontext.h
src/security/security_apparmor.h
src/security/security_dac.h
src/security/security_driver.h
src/security/security_selinux.h
src/security/security_stack.h
src/storage/storage_backend_iscsi_direct.h
src/storage/storage_backend_sheepdog.c
src/storage/storage_backend_sheepdog_priv.h
src/uml/uml_driver.h
src/util/viralloc.h
src/util/viratomic.h
src/util/viraudit.h
src/util/virbitmap.h
src/util/vircgrouppriv.h
src/util/vircommandpriv.h
src/util/virdbus.c
src/util/virdbuspriv.h
src/util/virebtables.h
src/util/virerror.h
src/util/vireventpoll.h
src/util/virfcp.h
src/util/virfdstream.h
src/util/virfile.h
src/util/virfirewallpriv.h
src/util/virgettext.h
src/util/virhash.h
src/util/virhostcpu.c
src/util/virhostcpu.h
src/util/virhostcpupriv.h
src/util/virhostmem.h
src/util/virinitctl.h
src/util/viriscsi.h
src/util/virjson.h
src/util/virkeycode.h
src/util/virlease.h
src/util/virlog.h
src/util/virmacmap.h
src/util/virnetdevvlan.h
src/util/virnodesuspend.h
src/util/virobject.h
src/util/virqemu.h
src/util/virresctrl.c
src/util/virresctrl.h
src/util/virresctrlpriv.h
src/util/virsexpr.h
src/util/virsysinfopriv.h
src/util/virsystemdpriv.h
src/util/virthread.h
src/util/virthreadjob.h
src/util/virthreadpool.h
src/util/virtime.h
src/util/virtpm.h
src/util/virtypedparam.h
src/util/virvhba.h
src/util/virxml.h
src/vbox/vbox_driver.h
src/vbox/vbox_snapshot_conf.h
src/vmware/vmware_conf.h
src/vmware/vmware_driver.h
src/vz/vz_driver.h
src/vz/vz_sdk.h
src/vz/vz_utils.h
src/xenapi/xenapi_driver.h
src/xenapi/xenapi_driver_private.h
tests/qemuhotplugtest.c
tests/qemumigparamstest.c
tests/qemumonitorjsontest.c
tests/qemumonitortestutils.c
tests/storagebackendsheepdogtest.c
tests/testutilshostcpus.h
tests/testutilslxc.h
tests/testutilsqemu.h
tests/testutilsqemuschema.h
tests/testutilsxen.h
tests/virdbustest.c
tests/virfilewrapper.h
tests/virfirewalltest.c
tests/virhashdata.h
tests/virhostcputest.c
tests/virnettlshelpers.h
tests/virresctrltest.c
tools/virsh-completer.h
tools/virt-admin-completer.h
tools/wireshark/src/packet-libvirt.h