]> xenbits.xensource.com Git - xen.git/commit
tools/dombuilder: Correct the length calculation in xc_dom_alloc_segment()
authorAndrew Cooper <andrew.cooper3@citrix.com>
Thu, 27 Jun 2024 12:22:14 +0000 (13:22 +0100)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Tue, 2 Jul 2024 09:50:18 +0000 (10:50 +0100)
commit4c3a618b0adaa0cd59e0fa0898bb60978b8b3a5f
tree7f493ac112f60be47a34ac0a0def280293c20616
parent9ec74bdb2582dc5b0517e05a3650d24745889c2b
tools/dombuilder: Correct the length calculation in xc_dom_alloc_segment()

xc_dom_alloc_segment() is passed a size in bytes, calculates a size in pages
from it, then fills in the new segment information with a bytes value
re-calculated from the number of pages.

This causes the module information given to the guest (MB, or PVH) to have
incorrect sizes; specifically, sizes rounded up to the next page.

This in turn is problematic for Xen.  When Xen finds a gzipped module, it
peeks at the end metadata to judge the decompressed size, which is a -4
backreference from the reported end of the module.

Fill in seg->vend using the correct number of bytes.

Fixes: ea7c8a3d0e82 ("libxc: reorganize domain builder guest memory allocator")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Anthony PERARD <anthony.perard@vates.tech>
Release-Acked-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
tools/libs/guest/xg_dom_core.c