]> xenbits.xensource.com Git - qemu-xen.git/commit
tests/avocado: exec_command should not consume console output
authorNicholas Piggin <npiggin@gmail.com>
Mon, 5 Aug 2024 23:28:12 +0000 (09:28 +1000)
committerPhilippe Mathieu-Daudé <philmd@linaro.org>
Mon, 19 Aug 2024 22:49:13 +0000 (00:49 +0200)
commit4a85f23157f7ff766608c1373b71a97513215257
tree8df5bfefd9904dcb8cdf76c864cfc2187bb72139
parente922abf5c0e40eb451434c4121b730c8a19d80d4
tests/avocado: exec_command should not consume console output

_console_interaction reads data from the console even when there is only
an input string to send, and no output data to wait on. This can cause
lines to be missed by wait_for_console_pattern calls that follows an
exec_command. Fix this by not reading the console if there is no pattern
to wait for.

This solves occasional hangs in ppc_hv_tests.py, usually when run on KVM
hosts that are fast enough to output important lines quickly enough to be
consumed by exec_command, so they get missed by subsequent wait for
pattern calls.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20240805232814.267843-2-npiggin@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
tests/avocado/avocado_qemu/__init__.py