]> xenbits.xensource.com Git - libvirt.git/commit
docs: Remove unnecessary <auth> example for iscsi disk type='volume'
authorJohn Ferlan <jferlan@redhat.com>
Wed, 13 Sep 2017 18:22:55 +0000 (14:22 -0400)
committerJohn Ferlan <jferlan@redhat.com>
Fri, 15 Sep 2017 11:37:50 +0000 (07:37 -0400)
commit4775ca27e9c5fb0c9248201ccb541595020c370c
tree58bd9578143c0f1986459f845febdca6ff7452bb
parenta823d0a62e858a62a585a78599b6d859c5b4dcac
docs: Remove unnecessary <auth> example for iscsi disk type='volume'

Alter the example to remove the <auth> from:

  <disk type='volume' device='disk'>
    <driver name='qemu' type='raw'/>
    <source pool='iscsi-pool' volume='unit:0:0:1' mode='host'/>
    <auth username='myuser'>
      <secret type='iscsi' usage='libvirtiscsi'/>
    </auth>
    <target dev='vdb' bus='virtio'/>
  </disk>

and

  <disk type='volume' device='disk'>
    <driver name='qemu' type='raw'/>
    <source pool='iscsi-pool' volume='unit:0:0:2' mode='direct'/>
    <auth username='myuser'>
      <secret type='iscsi' usage='libvirtiscsi'/>
    </auth>
    <target dev='vdc' bus='virtio'/>
  </disk>

The reality is, it's not even used. For a <source pool> the authdef
from the storage source pool will supercede whatever is in the <disk>
definition during virStorageTranslateDiskSourcePool processing. In fact,
if the pool doesn't have/need authentication, then the authdef would
be removed anyway as the storage pool would be handling things.

The "proof" for this is in the adjustment to the test to add an
<auth> for a disk. The resulting .args file won't add what normally
would be added "myname:encodedpassword@" prior to the hostname in
the IQN (e.g. iscsi://myname:encodedpassword@iscsi.example.org:3260/...
docs/formatdomain.html.in
tests/qemuxml2argvdata/qemuxml2argv-disk-source-pool-mode.args
tests/qemuxml2argvdata/qemuxml2argv-disk-source-pool-mode.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-source-pool-mode.xml