]> xenbits.xensource.com Git - qemu-xen.git/commit
x86_iommu/amd: remove V=1 check from amdvi_validate_dte()
authorSingh, Brijesh <brijesh.singh@amd.com>
Mon, 1 Oct 2018 19:44:32 +0000 (19:44 +0000)
committerMichael S. Tsirkin <mst@redhat.com>
Mon, 5 Nov 2018 18:24:02 +0000 (13:24 -0500)
commit470506b5821c62d6b00d0dd82eea999b61c3719e
tree9de12275d5b84b7dd57b8c48883b1d049f621954
parent35c2450191634bd0ac0ae3c6e9da3f590124e8e2
x86_iommu/amd: remove V=1 check from amdvi_validate_dte()

Currently, the amdvi_validate_dte() assumes that a valid DTE will
always have V=1. This is not true. The V=1 means that bit[127:1] are
valid. A valid DTE can have IV=1 and V=0 (i.e address translation
disabled and interrupt remapping enabled)

Remove the V=1 check from amdvi_validate_dte(), make the caller
responsible to check for V or IV bits.

This also fixes a bug in existing code that when error is
detected during the translation we'll fail the translation
instead of assuming a passthrough mode.

Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Cc: Peter Xu <peterx@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Richard Henderson <rth@twiddle.net>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Cc: Tom Lendacky <Thomas.Lendacky@amd.com>
Cc: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
hw/i386/amd_iommu.c