]> xenbits.xensource.com Git - libvirt.git/commit
build: silence coverity false positives
authorEric Blake <eblake@redhat.com>
Tue, 2 Aug 2011 20:26:17 +0000 (14:26 -0600)
committerEric Blake <eblake@redhat.com>
Tue, 2 Aug 2011 22:39:01 +0000 (16:39 -0600)
commit44ebb18ec22d66a7fc1d52a8547042b97d5d8689
treec42f87b75e2a6bb02e0e43f5aba48fc7f88980dc
parent2ea9409a88f9f25aa0cc2727d6d6daf5e4f97615
build: silence coverity false positives

Coverity complained that 395 out of 409 virAsprintf calls are
checked, and therefore assumed that the remaining cases are bugs
waiting to happen.  But in each of these cases, a failed virAsprintf
will properly set the target string to NULL, and pass on that
failure to the caller, without wasting efforts to check the call.
Adding the ignore_value silences Coverity.

* src/conf/domain_audit.c (virDomainAuditGetRdev): Ignore
virAsprintf return value, when it behaves like we need.
* src/network/bridge_driver.c (networkDnsmasqLeaseFileNameDefault)
(networkRadvdConfigFileName, networkBridgeDummyNicName)
(networkRadvdPidfileBasename): Likewise.
* src/util/storage_file.c (absolutePathFromBaseFile): Likewise.
* src/openvz/openvz_driver.c (openvzGenerateContainerVethName):
Likewise.
* src/util/command.c (virCommandTranslateStatus): Likewise.
src/conf/domain_audit.c
src/network/bridge_driver.c
src/openvz/openvz_driver.c
src/util/command.c
src/util/storage_file.c