]> xenbits.xensource.com Git - qemu-xen.git/commit
virtiofsd: Drop membership of all supplementary groups (CVE-2022-0358)
authorVivek Goyal <vgoyal@redhat.com>
Tue, 25 Jan 2022 18:51:14 +0000 (13:51 -0500)
committerDr. David Alan Gilbert <dgilbert@redhat.com>
Wed, 26 Jan 2022 10:32:05 +0000 (10:32 +0000)
commit449e8171f96a6a944d1f3b7d3627ae059eae21ca
tree587e621fd8db7cb3c6f4b76b3ba4d3a95aeab3fa
parentaeb0ae95b7f18c66158792641cb6ba0cde5789ab
virtiofsd: Drop membership of all supplementary groups (CVE-2022-0358)

At the start, drop membership of all supplementary groups. This is
not required.

If we have membership of "root" supplementary group and when we switch
uid/gid using setresuid/setsgid, we still retain membership of existing
supplemntary groups. And that can allow some operations which are not
normally allowed.

For example, if root in guest creates a dir as follows.

$ mkdir -m 03777 test_dir

This sets SGID on dir as well as allows unprivileged users to write into
this dir.

And now as unprivileged user open file as follows.

$ su test
$ fd = open("test_dir/priviledge_id", O_RDWR|O_CREAT|O_EXCL, 02755);

This will create SGID set executable in test_dir/.

And that's a problem because now an unpriviliged user can execute it,
get egid=0 and get access to resources owned by "root" group. This is
privilege escalation.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2044863
Fixes: CVE-2022-0358
Reported-by: JIETAO XIAO <shawtao1125@gmail.com>
Suggested-by: Miklos Szeredi <mszeredi@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Message-Id: <YfBGoriS38eBQrAb@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
  dgilbert: Fixed missing {}'s style nit
tools/virtiofsd/passthrough_ll.c