]> xenbits.xensource.com Git - libvirt.git/commit
vsh: cmdComplete: Don't leak buffer for completion
authorPeter Krempa <pkrempa@redhat.com>
Thu, 25 Apr 2024 08:05:42 +0000 (10:05 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Thu, 25 Apr 2024 12:13:19 +0000 (14:13 +0200)
commit41400ac1dda55b817388a4050aa823051bda2e05
treeb841d009d784722fced7958fe9e8b60a087b1212
parentac9c3c0b2ce4ce8b2501ec3f2e27fe2bf4dd61f4
vsh: cmdComplete: Don't leak buffer for completion

The buffer which we assign to the 'rl_line_buffer' variable of readline
would be overwritten and thus leaked on multiple invocations of
cmdComplete in one session.

Free/clear it after it's used.

Hitting this leak was until recenly possible only in non-interactive
batch mode and recently also in interactive mode as 'complete' can be
used multiple times now interactively.

Fixes: a0e1ada63c0afdc2af3b9405cbf637d8bd28700c
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
tools/vsh.c