]> xenbits.xensource.com Git - people/aperard/linux.git/commit
mfd: syscon: Call of_node_put() only when of_parse_phandle() takes a ref
authorPeter Griffin <peter.griffin@linaro.org>
Tue, 20 Feb 2024 11:50:10 +0000 (11:50 +0000)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:20:50 +0000 (18:20 -0400)
commit3eb47e41c2057fb6db5f73a60f35705450d80c08
treee903ebefc780d9e641e55554cc430abf8ed82399
parent527480cab5ccd85beb355f7ac4a27903eabc7348
mfd: syscon: Call of_node_put() only when of_parse_phandle() takes a ref

[ Upstream commit d2b0680cf3b05490b579e71b0df6e07451977745 ]

of_parse_phandle() returns a device_node with refcount incremented, which
the callee needs to call of_node_put() on when done. We should only call
of_node_put() when the property argument is provided though as otherwise
nothing has taken a reference on the node.

Fixes: 45330bb43421 ("mfd: syscon: Allow property as NULL in syscon_regmap_lookup_by_phandle")
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Link: https://lore.kernel.org/r/20240220115012.471689-2-peter.griffin@linaro.org
Signed-off-by: Lee Jones <lee@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mfd/syscon.c