]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/qemu-xen-traditional.git/commit
pcnet: force the buffer access to be in bounds during tx
authorPetr Matousek <pmatouse@redhat.com>
Sun, 24 May 2015 08:53:44 +0000 (10:53 +0200)
committerIan Jackson <Ian.Jackson@eu.citrix.com>
Tue, 23 Jun 2015 10:42:15 +0000 (11:42 +0100)
commit3e2e51ecc1120bd59537ed19b6bc7066511c7e2e
tree3b3f19aeb2aca60026f0a75f652b51a4df7175ed
parente2b999d45587de154d198891185cff47151e8418
pcnet: force the buffer access to be in bounds during tx

4096 is the maximum length per TMD and it is also currently the size of
the relay buffer pcnet driver uses for sending the packet data to QEMU
for further processing. With packet spanning multiple TMDs it can
happen that the overall packet size will be bigger than sizeof(buffer),
which results in memory corruption.

Fix this by only allowing to queue maximum sizeof(buffer) bytes.

This is CVE-2015-3209.

Signed-off-by: Petr Matousek <pmatouse@redhat.com>
Reported-by: Matt Tait <matttait@google.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
hw/pcnet.c