]> xenbits.xensource.com Git - libvirt.git/commit
qemuBuildRBDSecinfoURI: Use virSecureEraseString instead of VIR_AUTODISPOSE_STR
authorPeter Krempa <pkrempa@redhat.com>
Tue, 2 Feb 2021 16:04:30 +0000 (17:04 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 3 Feb 2021 12:07:13 +0000 (13:07 +0100)
commit3b1d2ff51022fa1e29a79c3b9339eff75355018c
tree2a271327b38ec4cd0093fb6f314484d7c799e225
parentffc13e76acc94957eb89d0ff22827856e9b07edf
qemuBuildRBDSecinfoURI: Use virSecureEraseString instead of VIR_AUTODISPOSE_STR

In this instance attempting to be correct is really pointless since the
secret is formatted into another string which is not erased securely and
then put on the commandline.

Keep the secure handling for correctness.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
src/qemu/qemu_command.c