]> xenbits.xensource.com Git - qemu-xen.git/commit
hw/char/riscv_htif: Fix printing of console characters on big endian hosts
authorThomas Huth <thuth@redhat.com>
Fri, 21 Jul 2023 09:47:19 +0000 (11:47 +0200)
committerMichael Tokarev <mjt@tls.msk.ru>
Tue, 12 Sep 2023 10:37:02 +0000 (13:37 +0300)
commit3af03de983108bc8c60a1a274b3e81a9553d4ce1
treef5084e2c53c0e6fc96fdf92219cfd2f251b3ef53
parent53a4e7ef420a2e272907b98fd8ffc199bcdc0e06
hw/char/riscv_htif: Fix printing of console characters on big endian hosts

The character that should be printed is stored in the 64 bit "payload"
variable. The code currently tries to print it by taking the address
of the variable and passing this pointer to qemu_chr_fe_write(). However,
this only works on little endian hosts where the least significant bits
are stored on the lowest address. To do this in a portable way, we have
to store the value in an uint8_t variable instead.

Fixes: 5033606780 ("RISC-V HTIF Console")
Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Bin Meng <bmeng@tinylab.org>
Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20230721094720.902454-2-thuth@redhat.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
(cherry picked from commit c255946e3df4d9660e4f468a456633c24393d468)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
hw/char/riscv_htif.c