]> xenbits.xensource.com Git - libvirt.git/commit
virnodedeviceobj: Don't unlock virNodeDeviceObj in virNodeDeviceObjListRemove()
authorMichal Privoznik <mprivozn@redhat.com>
Tue, 1 Feb 2022 14:40:23 +0000 (15:40 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Thu, 3 Feb 2022 08:37:44 +0000 (09:37 +0100)
commit39ac285c6b8f69e1503adfdce5cc1ef66181f9ed
treede6f1c28b47c16c630f972546018b656346427f4
parent41e878859ac7eb4059f2e9b338e585e205fd575c
virnodedeviceobj: Don't unlock virNodeDeviceObj in virNodeDeviceObjListRemove()

When virNodeDeviceObjListRemove() is called, the passed
virNodeDeviceObj is removed from internal list of node devices
and then unrefed and unlocked. While the former is warranted (the
object was refed at the beginning of the function) the unlock is
not. In fact, it's wrong from conceptual POV. We still want
threads working on the object tu mutually exclude each other.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
src/conf/virnodedeviceobj.c
src/test/test_driver.c