]> xenbits.xensource.com Git - qemu-upstream-4.6-testing.git/commit
target-arm/translate-a64: Fix wrong mmu_idx usage for LDT/STT
authorPeter Maydell <peter.maydell@linaro.org>
Thu, 5 Feb 2015 13:37:23 +0000 (13:37 +0000)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Mon, 23 Feb 2015 00:38:35 +0000 (18:38 -0600)
commit3750d2588e8d8d204820fef4ce95d7c271bafd3f
tree4d3b89cd79c950709ca63a5e4632761572be38b7
parent4ac8b01fa8de00bb649d0b87c1dc542e50dcf530
target-arm/translate-a64: Fix wrong mmu_idx usage for LDT/STT

The LDT/STT (load/store unprivileged) instruction decode was using
the wrong MMU index value. This meant that instead of these insns
being "always access as if user-mode regardless of current privilege"
they were "always access as if kernel-mode regardless of current
privilege". This went unnoticed because AArch64 Linux doesn't use
these instructions.

Cc: qemu-stable@nongnu.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Greg Bellows <greg.bellows@linaro.org>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---
I'm not counting this as a security issue because I'm assuming
nobody treats TCG guests as a security boundary (certainly I
would not recommend doing so...)

(cherry picked from commit 949013ce111eb64f8bc81cf9a9f1cefd6a1678c3)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
target-arm/translate-a64.c