]> xenbits.xensource.com Git - libvirt.git/commit
Revert "network: Check for QOS before blindly using it"
authorErik Skultety <eskultet@redhat.com>
Fri, 22 Nov 2019 15:21:33 +0000 (16:21 +0100)
committerErik Skultety <eskultet@redhat.com>
Mon, 25 Nov 2019 08:41:40 +0000 (09:41 +0100)
commit36a01c2a472062e2de7752f38d3fbeaf623ec064
tree29715f373e5590875cd94df750676d865b3c271b
parentbc7e72914a07db9050eab2df8341262c46035717
Revert "network: Check for QOS before blindly using it"

This reverts commit f4db846c32c0a1e99a0f62b340273e48f8a98ed3.

This patch results in the following error when trying to start
essentially any VM with default network:

unsupported configuration: QOS must be defined for network 'default'

Coverity didn't see that the bandwidth == NULL it complained about in
virNetDevBandwidthPlug was already checked properly in
networkCheckBandwidth, thus causing networkPlugBandwidth to return 0
and finish before a call to virNetDevBandwidthPlug would have been even
made.

Signed-off-by: Erik Skultety <eskultet@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/network/bridge_driver.c