]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commit
Fix potential deadlock when agent is closed
authorDaniel P. Berrange <berrange@redhat.com>
Wed, 26 Sep 2012 15:23:24 +0000 (16:23 +0100)
committerDaniel P. Berrange <berrange@redhat.com>
Thu, 27 Sep 2012 09:11:44 +0000 (10:11 +0100)
commit362d04779ce925725125a4eaa660c89d7313725f
tree7242ad73f55d23a2f7090a206605445c3c7edc8d
parent5cbb0d37d435c47c90e2d06e0f6efa5b8526f3e9
Fix potential deadlock when agent is closed

If the qemuAgentClose method is called from a place which holds
the domain lock, it is theoretically possible to get a deadlock
in the agent destroy callback. This has not been observed, but
the equivalent code in the QEMU monitor destroy callback has seen
a deadlock.

Remove the redundant locking while unrefing the object and the
bogus assignment

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
src/qemu/qemu_process.c