]> xenbits.xensource.com Git - libvirt.git/commit
qemu: don't release network actual device twice
authorRoopa Prabhu <roprabhu@cisco.com>
Thu, 17 Nov 2011 02:34:32 +0000 (18:34 -0800)
committerEric Blake <eblake@redhat.com>
Mon, 21 Nov 2011 21:42:33 +0000 (14:42 -0700)
commit334c539ba0178c7b71253c19e92999267386678e
tree8223822d85392afbc9564b2e0acc0a7488b13f30
parent2e37bf42d28d8bb5d045b206587c64643c64d02a
qemu: don't release network actual device twice

For direct attach devices, in qemuBuildCommandLine, we seem to be freeing
actual device on error path (with networkReleaseActualDevice). But the actual
device is not deleted.

qemuProcessStop eventually deletes the direct attach device and releases
actual device. But by the time qemuProcessStop is called qemuBuildCommandLine
has already freed actual device, leaving stray macvtap devices behind on error.
So the simplest fix is to remove the networkReleaseActualDevice in
qemuBuildCommandLine. This patch does just that.

Signed-off-by: Roopa Prabhu <roprabhu@cisco.com>
src/qemu/qemu_command.c