]> xenbits.xensource.com Git - qemu-upstream-4.5-testing.git/commit
xenfb: avoid reading twice the same fields from the shared page
authorStefano Stabellini <stefano.stabellini@eu.citrix.com>
Fri, 18 Dec 2015 15:10:09 +0000 (15:10 +0000)
committerStefano Stabellini <stefano.stabellini@eu.citrix.com>
Fri, 18 Dec 2015 15:35:50 +0000 (15:35 +0000)
commit32bba3499008c847e08858f310d65806e0bade36
tree48c0b5b7f32a091de4614863c7c24ee74c1f0db4
parenta83c1576bd330965784cfea72c7fc6e9b1838fdc
xenfb: avoid reading twice the same fields from the shared page

Reading twice the same field could give the guest an attack of
opportunity. In the case of event->type, gcc could compile the switch
statement into a jump table, effectively ending up reading the type
field multiple times.

This is part of XSA-155.

Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
hw/display/xenfb.c