]> xenbits.xensource.com Git - qemu-upstream-4.4-testing.git/commit
pcnet: force the buffer access to be in bounds during tx qemu-xen-4.4.3-rc1
authorPetr Matousek <pmatouse@redhat.com>
Sun, 24 May 2015 08:53:44 +0000 (10:53 +0200)
committerStefano Stabellini <stefano.stabellini@eu.citrix.com>
Wed, 10 Jun 2015 11:45:20 +0000 (11:45 +0000)
commit32226f429cca6c79826364d8d18acb2226f2f102
tree943244e66f3f3adff7550e77bfe30406331f9748
parent2800559b13911c2c128021313f2e367e44112a17
pcnet: force the buffer access to be in bounds during tx

4096 is the maximum length per TMD and it is also currently the size of
the relay buffer pcnet driver uses for sending the packet data to QEMU
for further processing. With packet spanning multiple TMDs it can
happen that the overall packet size will be bigger than sizeof(buffer),
which results in memory corruption.

Fix this by only allowing to queue maximum sizeof(buffer) bytes.

This is CVE-2015-3209.

Signed-off-by: Petr Matousek <pmatouse@redhat.com>
Reported-by: Matt Tait <matttait@google.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
hw/net/pcnet.c