]> xenbits.xensource.com Git - libvirt.git/commit
libvirtd: Fix order of cleanup processing
authorJohn Ferlan <jferlan@redhat.com>
Mon, 6 Nov 2017 20:20:55 +0000 (15:20 -0500)
committerJohn Ferlan <jferlan@redhat.com>
Sat, 18 Nov 2017 12:51:43 +0000 (07:51 -0500)
commit2f3054c22a85b06299f4c472ba71cb8760c7a67c
tree8a9ca0b01b8ba7fc7e7d7eb5a070c8f76bb83403
parent723cadd9ff4a728985806c27776fadd6e3d25fef
libvirtd: Fix order of cleanup processing

Current cleanup processing is ad-hoc at best - it's led to a couple of
strange and hard to diagnose timing problems and crashes.

So rather than perform cleanup in a somewhat random order, let's
perform cleanup in the exact opposite order of startup.

NB: It is possible that virNetlinkEventServerStart fails and we jump
to cleanup before driversInitialized has been set. That could leave
things inconsistent; however, resolution of that possibility is perhaps
more trouble than it's worth to handle.

Signed-off-by: John Ferlan <jferlan@redhat.com>
daemon/libvirtd.c