]> xenbits.xensource.com Git - libvirt.git/commit
qemu_capabilities: Put only unique FW images into domcaps
authorMichal Privoznik <mprivozn@redhat.com>
Thu, 12 Sep 2019 11:07:31 +0000 (13:07 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Tue, 1 Oct 2019 07:19:23 +0000 (09:19 +0200)
commit2f163204ff0edd33f67f4d41a503f6abe033c9ee
tree97f60ce9613f7b25d35abfd4b85d8d18957839be
parent808fa349f3e9c89702c84a307ab867ef2b4799c1
qemu_capabilities: Put only unique FW images into domcaps

In the domain capabilities XML there are FW image paths printed.
There are two sources for the image paths (in order of
preference):

  1) firmware descriptor files - as returned by
  qemuFirmwareGetSupported()

  2) a compile time list of FW:NRAM pairs which can be overridden
  in qemu.conf

If either of those contains a duplicate FW image path (which is
a valid use case) it is printed twice in the capabilities XML.
While it's technically not a bug, it doesn't look good.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Tested-by: Kashyap Chamarthy <kchamart@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
src/qemu/qemu_capabilities.c