]> xenbits.xensource.com Git - qemu-upstream-4.4-testing.git/commit
qdev-monitor: Fix crash when device_add is called with abstract driver
authorIgor Mammedov <imammedo@redhat.com>
Tue, 17 Sep 2013 13:32:32 +0000 (15:32 +0200)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Mon, 9 Dec 2013 17:40:30 +0000 (11:40 -0600)
commit2cafbbf1e03b954dedd3643ab3a4ffe685a63ccf
tree7756e2628f1f34c1928042d3dcaefae10e03cad1
parent991a5f378261b759b2af2354703c504906418d35
qdev-monitor: Fix crash when device_add is called with abstract driver

User is able to crash running QEMU when following monitor
command is called:

 device_add intel-hda-generic

Crash is caused by assertion in object_initialize_with_type()
when type is abstract.

Checking if type is abstract before instance is created in
qdev_device_add() allows to prevent crash on incorrect user input.

Cc: qemu-stable@nongnu.org
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
(cherry picked from commit 2fa4e56d88aa0039062bbc7f9a88e9f90c77ed94)

Conflicts:

qdev-monitor.c

*updated to reflect different 1.6 variable names

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
qdev-monitor.c