]> xenbits.xensource.com Git - xenclient/kernel.git/commit
linux/acpi: adjust extcntl's changes to (mostly) common code, mostly for readability
authorKeir Fraser <keir.fraser@citrix.com>
Wed, 23 Jul 2008 13:20:56 +0000 (14:20 +0100)
committerKeir Fraser <keir.fraser@citrix.com>
Wed, 23 Jul 2008 13:20:56 +0000 (14:20 +0100)
commit2abf4a4df05f664e81bda885fc129bd2748ae52e
tree14d283b0d2ec7583238d0d7f8ffd4b25a9b92409
parent6d70380f8fae37d568ea2265e3be4b0e6c89db3f
linux/acpi: adjust extcntl's changes to (mostly) common code, mostly for readability

While I realize that it may have been upon my request that all these
#ifdef-s were introduced, I think this went too far here: With the
abstraction in include/acpi/processor.h in place, the code still
guarantees even without all these #ifdef-s that in native kernels
built from the same source the logic will not change.

The one thing that appears a little weak still is the NR_ACPI_CPUS
construct - nothing guarantees that the ACPI IDs are constrained to 8
bits, and hence using an array here doesn't seem either safe or
scalable looking forward. To make the issue explict, the patch adds a
respective BUG_ON().

Also remove a stray export.

Signed-off-by: Jan Beulich <jbeulich@novell.com>
arch/i386/kernel/acpi/processor_extcntl_xen.c
drivers/acpi/processor_core.c
drivers/acpi/processor_idle.c
drivers/acpi/processor_perflib.c
include/acpi/processor.h