]> xenbits.xensource.com Git - qemu-upstream-4.4-testing.git/commit
ide: Correct improper smart self test counter reset in ide core.
authorBenoît Canet <benoit.canet@irqsave.net>
Sat, 12 Apr 2014 20:59:50 +0000 (22:59 +0200)
committerStefano Stabellini <stefano.stabellini@eu.citrix.com>
Thu, 5 Mar 2015 14:53:21 +0000 (14:53 +0000)
commit29236c2ea0cc67fa831e2eb75ee729615c950751
tree3a9fe2e76a8af744cdb3b5f2e0cbb13cfc54d5bb
parenta86ea88b50d6a2931efcebdc2c3a350451f69b02
ide: Correct improper smart self test counter reset in ide core.

The SMART self test counter was incorrectly being reset to zero,
not 1. This had the effect that on every 21st SMART EXECUTE OFFLINE:
 * We would write off the beginning of a dynamically allocated buffer
 * We forgot the SMART history
Fix this.

Signed-off-by: Benoit Canet <benoit@irqsave.net>
Message-id: 1397336390-24664-1-git-send-email-benoit.canet@irqsave.net
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Cc: qemu-stable@nongnu.org
Acked-by: Kevin Wolf <kwolf@redhat.com>
[PMM: tweaked commit message as per suggestions from Markus]
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
hw/ide/core.c