]> xenbits.xensource.com Git - qemu-xen.git/commit
block: Do not truncate file node when formatting
authorMax Reitz <mreitz@redhat.com>
Wed, 18 Sep 2019 09:51:39 +0000 (11:51 +0200)
committerMax Reitz <mreitz@redhat.com>
Mon, 28 Oct 2019 10:59:57 +0000 (11:59 +0100)
commit26536c7fc25917d1bd13781f81fe3ab039643bff
treecca26ca0b0f205bb567b398f576e3e283beb0024
parentbb8160eb78e948b0ef6f5ebbd38ff2a2c3f1dcf3
block: Do not truncate file node when formatting

There is no reason why the format drivers need to truncate the protocol
node when formatting it.  When using the old .bdrv_co_create_ops()
interface, the file will be created with no size option anyway, which
generally gives it a size of 0.  (Exceptions are block devices, which
cannot be truncated anyway.)

When using blockdev-create, the user must have given the file node some
size anyway, so there is no reason why we should override that.

qed is an exception, it needs the file to start completely empty (as
explained by c743849bee7333c7ef256b7e12e34ed6f907064f).

Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-id: 20190918095144.955-4-mreitz@redhat.com
Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
block/parallels.c
block/qcow.c
block/qcow2.c