]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commit
libxl: limit support for specifying an interface script
authorJim Fehlig <jfehlig@suse.com>
Tue, 10 Jun 2014 20:53:55 +0000 (14:53 -0600)
committerJim Fehlig <jfehlig@suse.com>
Thu, 19 Jun 2014 21:33:36 +0000 (15:33 -0600)
commit2624dfde377e7664e445c7812955e14ca92bcf60
tree6832b7aa08515ff2e194ce2cefca9db5c515dea2
parentbf410bb8ebd6ff45665f51cebedf1b8c75f7bef9
libxl: limit support for specifying an interface script

Generally, <interface> ... <script> is only supported for
type='ethernet'.  Due to the long and pervasive use of

  <interface type='bridge'>
    ...
    <script path='foo'/>
  </interface>

in Xen domain configuration, it was agreed to allow the use
of <script> with type='bridge' for backwards compatibility.  See
the following discussion thread

http://www.redhat.com/archives/libvir-list/2013-April/msg00755.html

This patch limits the use of <script> to interface types ethernet
and bridge, raising an unsupported config error if <script> is
specified for all other interface types.

While at it, use VIR_ERR_CONFIG_UNSUPPORTED instead of
VIR_ERR_INTERNAL_ERROR when reporting unsupported interface types.
src/libxl/libxl_conf.c