]> xenbits.xensource.com Git - libvirt.git/commit
build: avoid useless virAsprintf
authorEric Blake <eblake@redhat.com>
Thu, 2 May 2013 19:35:26 +0000 (13:35 -0600)
committerEric Blake <eblake@redhat.com>
Thu, 2 May 2013 19:35:26 +0000 (13:35 -0600)
commit25ae3d301508a6a9db7cdc5678ef5d93e793d9b8
treec5280001d1c7f449c505a1fd748e2b83853d75d1
parent5a3487dadb04bbba4bec9aed102ac83568d47363
build: avoid useless virAsprintf

virAsprintf(&foo, "%s", bar) is wasteful compared to
foo = strdup(bar) (or eventually, VIR_STRDUP(foo, bar),
but one thing at a time...).

Noticed while reviewing Laine's attempt to clean up broken
qemu:///session.

* cfg.mk (sc_prohibit_asprintf): Enhance rule.
* src/esx/esx_storage_backend_vmfs.c
(esxStorageBackendVMFSVolumeLookupByKey): Fix offender.
* src/network/bridge_driver.c (networkStateInitialize): Likewise.
* src/nwfilter/nwfilter_dhcpsnoop.c (virNWFilterSnoopDHCPOpen):
Likewise.
* src/storage/storage_backend_sheepdog.c
(virStorageBackendSheepdogRefreshVol): Likewise.
* src/util/vircgroup.c (virCgroupAddTaskStrController): Likewise.
* src/util/virdnsmasq.c (addnhostsAdd): Likewise.
* src/xen/block_stats.c (xenLinuxDomainDeviceID): Likewise.
* src/xen/xen_driver.c (xenUnifiedConnectOpen): Likewise.
* tools/virsh.c (vshGetTypedParamValue): Likewise.

Signed-off-by: Eric Blake <eblake@redhat.com>
cfg.mk
src/esx/esx_storage_backend_vmfs.c
src/network/bridge_driver.c
src/nwfilter/nwfilter_dhcpsnoop.c
src/storage/storage_backend_sheepdog.c
src/util/vircgroup.c
src/util/virdnsmasq.c
src/xen/block_stats.c
src/xen/xen_driver.c
tools/virsh.c