]> xenbits.xensource.com Git - libvirt.git/commit
Revert "domain_conf: check device address before attach"
authorMichal Privoznik <mprivozn@redhat.com>
Thu, 11 Apr 2019 13:40:51 +0000 (15:40 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Thu, 18 Apr 2019 15:09:40 +0000 (17:09 +0200)
commit22dc3e94c24b4d9a6c28beda91b9b283eb9b0251
tree982ac002500b46cc0a31e675ef6d66db38f4342d
parentddc72f99027b063feaf34e5fda89916b6b2c8943
Revert "domain_conf: check device address before attach"

This reverts commit f1d6585300001c7b23b8796a0faa4411c3531996.

Turns out, this caused a regression. There is this (perhaps less
known) semantic of virDomainAttachDevice() where if the device
the API is trying to attach is a CDROM/floppy that is already in
the domain the attach request is handled as 'change the media in
the drive'.

We have a better fix anyways.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Tested-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Reviewed-by: Jim Fehlig <jfehlig@suse.com>
src/conf/domain_conf.c