]> xenbits.xensource.com Git - qemu-upstream-4.3-testing.git/commit
qcow1: Validate L2 table size (CVE-2014-0222)
authorKevin Wolf <kwolf@redhat.com>
Thu, 5 Mar 2015 10:59:35 +0000 (10:59 +0000)
committerStefano Stabellini <stefano.stabellini@eu.citrix.com>
Thu, 5 Mar 2015 17:12:19 +0000 (17:12 +0000)
commit2247bc8c1b1234cc6a9c0c024b4fee1dd4e10e3a
tree7ee2382145608d5fb34f47bd1b24b5a8707de3d5
parent982dc223ed348860a96a960a2920792a2815208e
qcow1: Validate L2 table size (CVE-2014-0222)

Too large L2 table sizes cause unbounded allocations. Images actually
created by qemu-img only have 512 byte or 4k L2 tables.

To keep things consistent with cluster sizes, allow ranges between 512
bytes and 64k (in fact, down to 1 entry = 8 bytes is technically
working, but L2 table sizes smaller than a cluster don't make a lot of
sense).

This also means that the number of bytes on the virtual disk that are
described by the same L2 table is limited to at most 8k * 64k or 2^29,
preventively avoiding any integer overflows.

Cc: qemu-stable@nongnu.org
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
block/qcow.c