]> xenbits.xensource.com Git - legacy/linux-2.6.18-xen.git/commit
xenbus: fix type inconsistency with xenbus_conn()
authorJan Beulich <jbeulich@novell.com>
Sat, 2 Apr 2011 14:54:29 +0000 (15:54 +0100)
committerJan Beulich <jbeulich@novell.com>
Sat, 2 Apr 2011 14:54:29 +0000 (15:54 +0100)
commit2201744d87fd4b323f77a47d3c9e93cb9ca68bbb
treeeb79c2b8a7dfd8c5cea1e7dc252dcad3d8900070
parent306c0b0ed9a89b8b1968d1a10ba3c7be88e4ed83
xenbus: fix type inconsistency with xenbus_conn()

Its (bogus) declaration in xenbus_dev.c was inconsistent with the
actual implementation, leaving room for stack corruption on 64-bit
systems. Thus move the declaration to a header included by both
parties, and use proper types for the parameters.

Additionally, the function is needed on privileged kernels only, and
hence neither the potentially forward-incompatible HAVE_UNLOCKED_IOCTL
conditionals in xenbus_dev.c are needed, nor does the function (and
its helper) need to be compiled in unprivileged builds.

Signed-off-by: Jan Beulich <jbeulich@novell.com>
drivers/xen/xenbus/xenbus_comms.h
drivers/xen/xenbus/xenbus_dev.c
drivers/xen/xenbus/xenbus_probe.c