]> xenbits.xensource.com Git - libvirt.git/commit
Remove all direct use of getenv
authorDaniel P. Berrange <berrange@redhat.com>
Wed, 9 Oct 2013 10:18:15 +0000 (11:18 +0100)
committerDaniel P. Berrange <berrange@redhat.com>
Mon, 21 Oct 2013 13:03:52 +0000 (14:03 +0100)
commit1e4a02bdfe6307f93763fa2c9681f280c564aee5
treeda11dc1d0726743c2581adab11411009f7eeb979
parent9b8f307c6ad002a17a0510513883d06395636793
Remove all direct use of getenv

Unconditional use of getenv is not secure in setuid env.
While not all libvirt code runs in a setuid env (since
much of it only exists inside libvirtd) this is not always
clear to developers. So make all the code paranoid, even
if it only ever runs inside libvirtd.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
17 files changed:
daemon/libvirtd.c
src/driver.c
src/libvirt.c
src/locking/lock_daemon.c
src/locking/lock_driver_lockd.c
src/locking/lock_manager.c
src/lxc/lxc_driver.c
src/remote/remote_driver.c
src/rpc/virnettlscontext.c
src/util/virauth.c
src/util/virfile.c
src/util/virlog.c
src/util/virrandom.c
src/util/virutil.c
src/vbox/vbox_XPCOMCGlue.c
src/vbox/vbox_tmpl.c
tools/virsh.c