]> xenbits.xensource.com Git - xen.git/commit
x86/VT-x: Fix printing of EFER in vmcs_dump_vcpu()
authorAndrew Cooper <andrew.cooper3@citrix.com>
Wed, 4 Jul 2018 10:35:54 +0000 (12:35 +0200)
committerJan Beulich <jbeulich@suse.com>
Wed, 4 Jul 2018 10:35:54 +0000 (12:35 +0200)
commit19f4f879d2c9bda5c052e47e80feadb09ccda4f0
tree7e8f6ae11a1e2e485abd18e051672fd6c1603458
parentc4cb7d3b0b3e8b077057a2c13c539f80105c7337
x86/VT-x: Fix printing of EFER in vmcs_dump_vcpu()

This is essentially a "take 2" of c/s 82540b66ce "x86/VT-x: Fix determination
of EFER.LMA in vmcs_dump_vcpu()" because in hindight, that change was more
problematic than useful.

The original reason was to fix the logic for determining when not to print the
PDPTE pointers.  However, mutating the efer variable (particularly LME and
LMA) before printing it interferes with diagnosing vmentry failures.

Instead of modifying efer, change the PDPTE conditional to use
VM_ENTRY_IA32E_MODE.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Kevin Tian <kevin.tian@intel.com>
master commit: 35fcb982ea16c40619fee8bba4789a94d824521e
master date: 2018-06-05 11:55:51 +0100
xen/arch/x86/hvm/vmx/vmcs.c