]> xenbits.xensource.com Git - qemu-upstream-4.3-testing.git/commit
slirp: udp: fix NULL pointer dereference because of uninitialized socket
authorPetr Matousek <pmatouse@redhat.com>
Thu, 18 Sep 2014 06:35:37 +0000 (08:35 +0200)
committerStefano Stabellini <stefano.stabellini@eu.citrix.com>
Thu, 5 Mar 2015 13:21:57 +0000 (13:21 +0000)
commit17f77d73cec4dd4178e95c6b1abd2fa87daaef78
treea78030898c037ad02f31310a31ae0285ca6892cb
parent79c312d62dc8103285a254c9cc0485cc869ae734
slirp: udp: fix NULL pointer dereference because of uninitialized socket

When guest sends udp packet with source port and source addr 0,
uninitialized socket is picked up when looking for matching and already
created udp sockets, and later passed to sosendto() where NULL pointer
dereference is hit during so->slirp->vnetwork_mask.s_addr access.

Fix this by checking that the socket is not just a socket stub.

This is CVE-2014-3640.

Signed-off-by: Petr Matousek <pmatouse@redhat.com>
Reported-by: Xavier Mehrenberger <xavier.mehrenberger@airbus.com>
Reported-by: Stephane Duverger <stephane.duverger@eads.net>
Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Message-id: 20140918063537.GX9321@dhcp-25-225.brq.redhat.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
slirp/udp.c