]> xenbits.xensource.com Git - qemu-upstream-4.6-testing.git/commit
cirrus: fix oob access issue (CVE-2017-2615)
authorLi Qiang <liqiang6-s@360.cn>
Thu, 9 Feb 2017 22:36:41 +0000 (14:36 -0800)
committerStefano Stabellini <sstabellini@kernel.org>
Thu, 9 Feb 2017 22:44:23 +0000 (14:44 -0800)
commit15c0f1500fc078b6411d2c86842cb2f3fd7393c0
treeb95b67c005e639ea0cc067c847e16b276f9c42d1
parentba9175c5bde6796851d3b9d888ee488fd0257d05
cirrus: fix oob access issue (CVE-2017-2615)

When doing bitblt copy in backward mode, we should minus the
blt width first just like the adding in the forward mode. This
can avoid the oob access of the front of vga's vram.

This is XSA-208.

upstream-commit-id: 62d4c6bd5263bb8413a06c80144fc678df6dfb64

Signed-off-by: Li Qiang <liqiang6-s@360.cn>
{ kraxel: with backward blits (negative pitch) addr is the topmost
          address, so check it as-is against vram size ]

Cc: qemu-stable@nongnu.org
Cc: P J P <ppandit@redhat.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Wolfgang Bumiller <w.bumiller@proxmox.com>
Fixes: d3532a0db02296e687711b8cdc7791924efccea0 (CVE-2014-8106)
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Message-id: 1485938101-26602-1-git-send-email-kraxel@redhat.com
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
hw/display/cirrus_vga.c